Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: chrome/browser/extensions/activity_log/activity_log.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log.cc b/chrome/browser/extensions/activity_log/activity_log.cc
index f45237dc63a84d160c777cc1c5ffad97da0ae870..74cfad389d8fd60544663b918ace3713d0e074d2 100644
--- a/chrome/browser/extensions/activity_log/activity_log.cc
+++ b/chrome/browser/extensions/activity_log/activity_log.cc
@@ -278,7 +278,7 @@ void ExtractUrls(scoped_refptr<Action> action, Profile* profile) {
if (action->args()->GetString(url_index, &url_string) &&
ResolveUrl(action->page_url(), url_string, &arg_url)) {
action->mutable_args()->Set(url_index,
- new base::StringValue(kArgUrlPlaceholder));
+ new base::Value(kArgUrlPlaceholder));
}
break;
}
@@ -309,8 +309,8 @@ void ExtractUrls(scoped_refptr<Action> action, Profile* profile) {
// Single tab ID to translate.
GetUrlForTabId(tab_id, profile, &arg_url, &arg_incognito);
if (arg_url.is_valid()) {
- action->mutable_args()->Set(
- url_index, new base::StringValue(kArgUrlPlaceholder));
+ action->mutable_args()->Set(url_index,
+ new base::Value(kArgUrlPlaceholder));
}
} else if (action->mutable_args()->GetList(url_index, &tab_list)) {
// A list of possible IDs to translate. Work through in reverse order
@@ -320,13 +320,12 @@ void ExtractUrls(scoped_refptr<Action> action, Profile* profile) {
if (tab_list->GetInteger(i, &tab_id) &&
GetUrlForTabId(tab_id, profile, &arg_url, &arg_incognito)) {
if (!arg_incognito)
- tab_list->Set(i, new base::StringValue(arg_url.spec()));
+ tab_list->Set(i, new base::Value(arg_url.spec()));
extracted_index = i;
}
}
if (extracted_index >= 0) {
- tab_list->Set(
- extracted_index, new base::StringValue(kArgUrlPlaceholder));
+ tab_list->Set(extracted_index, new base::Value(kArgUrlPlaceholder));
}
}
break;

Powered by Google App Engine
This is Rietveld 408576698