Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3057)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 9fb95b9c421b5ecc52be8314ba3682e2b2481030..e39eee502e39aa4cc96320cc9984daf5cc8daaff 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -1674,7 +1674,7 @@ void TabsCaptureVisibleTabFunction::OnCaptureSuccess(const SkBitmap& bitmap) {
return;
}
- SetResult(base::MakeUnique<base::StringValue>(base64_result));
+ SetResult(base::MakeUnique<base::Value>(base64_result));
SendResponse(true);
}
@@ -1784,7 +1784,7 @@ void TabsDetectLanguageFunction::Observe(
}
void TabsDetectLanguageFunction::GotLanguage(const std::string& language) {
- SetResult(base::MakeUnique<base::StringValue>(language.c_str()));
+ SetResult(base::MakeUnique<base::Value>(language.c_str()));
SendResponse(true);
Release(); // Balanced in Run()

Powered by Google App Engine
This is Rietveld 408576698