base/json/json_writer_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_writer_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_writer_unittest.cc

diff --git a/base/json/json_writer_unittest.cc b/base/json/json_writer_unittest.cc

index 083fdc7eb403c14eddfa814ab047b85d7d00d955..6cb236fdc1e8fc8fb4ade9046f0a7ba732e6451f 100644

--- a/base/json/json_writer_unittest.cc

+++ b/base/json/json_writer_unittest.cc

@@ -47,7 +47,7 @@ TEST(JSONWriterTest, BasicTypes) {

EXPECT_EQ("-0.8", output_js);

// Test String values.

- EXPECT_TRUE(JSONWriter::Write(StringValue("foo"), &output_js));

+ EXPECT_TRUE(JSONWriter::Write(Value("foo"), &output_js));

EXPECT_EQ("\"foo\"", output_js);

}

« no previous file with comments | « base/json/json_perftest.cc ('k') | base/test/values_test_util.h » ('j') | no next file with comments »