Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/browser/extensions/extension_management_test_util.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_test_util.cc
diff --git a/chrome/browser/extensions/extension_management_test_util.cc b/chrome/browser/extensions/extension_management_test_util.cc
index 85b1946864e18867a12afbc8c46e305d0e7992d1..ec6313ca916d14c57f6661b86e9a15b1e3e3c9fc 100644
--- a/chrome/browser/extensions/extension_management_test_util.cc
+++ b/chrome/browser/extensions/extension_management_test_util.cc
@@ -233,8 +233,7 @@ void ExtensionManagementPrefUpdaterBase::AddStringToList(
list_value = new base::ListValue();
pref_->Set(path, list_value);
}
- CHECK(
- list_value->AppendIfNotPresent(base::MakeUnique<base::StringValue>(str)));
+ CHECK(list_value->AppendIfNotPresent(base::MakeUnique<base::Value>(str)));
}
void ExtensionManagementPrefUpdaterBase::RemoveStringFromList(
@@ -242,7 +241,7 @@ void ExtensionManagementPrefUpdaterBase::RemoveStringFromList(
const std::string& str) {
base::ListValue* list_value = nullptr;
if (pref_->GetList(path, &list_value))
- CHECK(list_value->Remove(base::StringValue(str), nullptr));
+ CHECK(list_value->Remove(base::Value(str), nullptr));
}
// ExtensionManagementPolicyUpdater --------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698