chrome/browser/ui/webui/bidi_checker_web_ui_test.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

index b4d9e47a098835b674f7ac08c1d5a93bc9223c40..36178005fbf96f750bb02524c468b91e17a0d127 100644

--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

@@ -103,8 +103,7 @@ void WebUIBidiCheckerBrowserTest::SetUpInProcessBrowserTestFixture() {

void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(

const std::string& page_url, bool is_rtl) {

ui_test_utils::NavigateToURL(browser(), GURL(page_url));

- ASSERT_TRUE(RunJavascriptTest("runBidiChecker",

- new base::StringValue(page_url),

+ ASSERT_TRUE(RunJavascriptTest("runBidiChecker", new base::Value(page_url),

new base::Value(is_rtl)));

}