Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
index ae8fbefa82a10384ebdf4e2bf57751ac4ca845b5..1bd814dd535cb66831c81df5caaaae5c4f3861df 100644
--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
@@ -143,7 +143,7 @@ TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {
TEST_F(PolicyValueStoreTest, ReadOnly) {
ValueStore::WriteOptions options = ValueStore::DEFAULTS;
- base::StringValue string_value("value");
+ base::Value string_value("value");
EXPECT_FALSE(store_->Set(options, "key", string_value)->status().ok());
base::DictionaryValue dict;
@@ -159,7 +159,7 @@ TEST_F(PolicyValueStoreTest, ReadOnly) {
TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
// Notify when setting the initial policy.
- const base::StringValue value("111");
+ const base::Value value("111");
{
ValueStoreChangeList changes;
changes.push_back(ValueStoreChange("aaa", nullptr, value.CreateDeepCopy()));
@@ -193,7 +193,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
Mock::VerifyAndClearExpectations(&observer_);
// Notify when policies change.
- const base::StringValue new_value("222");
+ const base::Value new_value("222");
{
ValueStoreChangeList changes;
changes.push_back(ValueStoreChange("bbb", value.CreateDeepCopy(),

Powered by Google App Engine
This is Rietveld 408576698