Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/activity_log/activity_actions.h" 5 #include "chrome/browser/extensions/activity_log/activity_actions.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 if (args_.get()) { 280 if (args_.get()) {
281 result += " ARGS=" + Serialize(args_.get()); 281 result += " ARGS=" + Serialize(args_.get());
282 } 282 }
283 if (page_url_.is_valid()) { 283 if (page_url_.is_valid()) {
284 if (page_incognito_) 284 if (page_incognito_)
285 result += " PAGE_URL=(incognito)" + page_url_.spec(); 285 result += " PAGE_URL=(incognito)" + page_url_.spec();
286 else 286 else
287 result += " PAGE_URL=" + page_url_.spec(); 287 result += " PAGE_URL=" + page_url_.spec();
288 } 288 }
289 if (!page_title_.empty()) { 289 if (!page_title_.empty()) {
290 base::StringValue title(page_title_); 290 base::Value title(page_title_);
291 result += " PAGE_TITLE=" + Serialize(&title); 291 result += " PAGE_TITLE=" + Serialize(&title);
292 } 292 }
293 if (arg_url_.is_valid()) { 293 if (arg_url_.is_valid()) {
294 if (arg_incognito_) 294 if (arg_incognito_)
295 result += " ARG_URL=(incognito)" + arg_url_.spec(); 295 result += " ARG_URL=(incognito)" + arg_url_.spec();
296 else 296 else
297 result += " ARG_URL=" + arg_url_.spec(); 297 result += " ARG_URL=" + arg_url_.spec();
298 } 298 }
299 if (other_.get()) { 299 if (other_.get()) {
300 result += " OTHER=" + Serialize(other_.get()); 300 result += " OTHER=" + Serialize(other_.get());
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other()); 362 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other());
363 if (lhs_other != rhs_other) 363 if (lhs_other != rhs_other)
364 return lhs_other < rhs_other; 364 return lhs_other < rhs_other;
365 } 365 }
366 366
367 // All fields compare as equal if this point is reached. 367 // All fields compare as equal if this point is reached.
368 return false; 368 return false;
369 } 369 }
370 370
371 } // namespace extensions 371 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698