Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: components/sync/base/model_type.h

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/base/model_type.h
diff --git a/components/sync/base/model_type.h b/components/sync/base/model_type.h
index c2840f1e9591be3b10695ade378908845f918bb9..34419ee9cd0c8f0dadf891c8d8a842d9132bccfa 100644
--- a/components/sync/base/model_type.h
+++ b/components/sync/base/model_type.h
@@ -17,7 +17,6 @@
namespace base {
class ListValue;
class Value;
-using StringValue = Value;
}
namespace sync_pb {
@@ -286,7 +285,7 @@ int ModelTypeToHistogramInt(ModelType model_type);
// Handles all model types, and not just real ones.
//
// Caller takes ownership of returned value.
-base::StringValue* ModelTypeToValue(ModelType model_type);
+base::Value* ModelTypeToValue(ModelType model_type);
// Converts a Value into a ModelType - complement to ModelTypeToValue().
ModelType ModelTypeFromValue(const base::Value& value);

Powered by Google App Engine
This is Rietveld 408576698