Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6241)

Unified Diff: chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc b/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
index 282c552f75f212e1710968c9c53be8e2226c8b55..fc01881bd0d62d559decc58a74e67d0b8c95d2e7 100644
--- a/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
@@ -43,7 +43,7 @@ void FirstRunHandler::RemoveBackgroundHoles() {
void FirstRunHandler::ShowStepPositioned(const std::string& name,
const StepPosition& position) {
web_ui()->CallJavascriptFunctionUnsafe(
- "cr.FirstRun.showStep", base::StringValue(name), *position.AsValue());
+ "cr.FirstRun.showStep", base::Value(name), *position.AsValue());
}
void FirstRunHandler::ShowStepPointingTo(const std::string& name,
@@ -55,9 +55,8 @@ void FirstRunHandler::ShowStepPointingTo(const std::string& name,
point_with_offset.AppendInteger(x);
point_with_offset.AppendInteger(y);
point_with_offset.AppendInteger(offset);
- web_ui()->CallJavascriptFunctionUnsafe("cr.FirstRun.showStep",
- base::StringValue(name), *null,
- point_with_offset);
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "cr.FirstRun.showStep", base::Value(name), *null, point_with_offset);
}
void FirstRunHandler::HideCurrentStep() {

Powered by Google App Engine
This is Rietveld 408576698