components/sync/engine_impl/js_mutation_event_observer.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/js_mutation_event_observer.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/js_mutation_event_observer.cc

diff --git a/components/sync/engine_impl/js_mutation_event_observer.cc b/components/sync/engine_impl/js_mutation_event_observer.cc

index a4af4da76b4099508d45c893e2915cab342311c8..2554b1aafa2fb712a2a37bbad7a21dba15d0eb1a 100644

--- a/components/sync/engine_impl/js_mutation_event_observer.cc

+++ b/components/sync/engine_impl/js_mutation_event_observer.cc

@@ -64,7 +64,7 @@ void JsMutationEventObserver::OnChangesApplied(

changes_value = changes_list;

} else {

changes_value =

- new base::StringValue(base::SizeTToString(changes_size) + " changes");

+ new base::Value(base::SizeTToString(changes_size) + " changes");

}

details.Set("changes", changes_value);

HandleJsEvent(FROM_HERE, "onChangesApplied", JsEventDetails(&details));