net/log/file_net_log_observer_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/file_net_log_observer_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/file_net_log_observer_unittest.cc

diff --git a/net/log/file_net_log_observer_unittest.cc b/net/log/file_net_log_observer_unittest.cc

index 66c61c147287655d1b3474fbcc7fbce0f9737b1d..84dcc98612ba549ce6e612e1485ad722d4524bf7 100644

--- a/net/log/file_net_log_observer_unittest.cc

+++ b/net/log/file_net_log_observer_unittest.cc

@@ -334,8 +334,7 @@ TEST_P(FileNetLogObserverTest, CustomConstants) {

TestClosure closure;

const char kConstantString[] = "awesome constant";

- std::unique_ptr<base::Value> constants(

- new base::StringValue(kConstantString));

+ std::unique_ptr<base::Value> constants(new base::Value(kConstantString));

CreateAndStartObserving(std::move(constants));

« no previous file with comments | « net/http/transport_security_state.cc ('k') | net/log/net_log_with_source.cc » ('j') | no next file with comments »