Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: headless/lib/browser/devtools_api/domain_type_conversions_h.template

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/api/identity/identity_api.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/devtools_api/domain_type_conversions_h.template
diff --git a/headless/lib/browser/devtools_api/domain_type_conversions_h.template b/headless/lib/browser/devtools_api/domain_type_conversions_h.template
index f14b423a66a397733d4f6d81b9b0377817a77d1d..15796eb756d3212d5b6e03f2f8aba77b909b982d 100644
--- a/headless/lib/browser/devtools_api/domain_type_conversions_h.template
+++ b/headless/lib/browser/devtools_api/domain_type_conversions_h.template
@@ -40,7 +40,7 @@ std::unique_ptr<base::Value> ToValueImpl(const {{namespace}}::{{type.id}}& value
switch (value) {
{% for literal in type.enum %}
case {{namespace}}::{{type.id}}::{{literal | sanitize_literal | dash_to_camelcase | camelcase_to_hacker_style | upper }}:
- return base::WrapUnique(new base::StringValue("{{literal}}"));
+ return base::WrapUnique(new base::Value("{{literal}}"));
{% endfor %}
};
NOTREACHED();
« no previous file with comments | « extensions/shell/browser/api/identity/identity_api.cc ('k') | headless/public/internal/value_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698