chromeos/dbus/fake_shill_device_client.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_shill_device_client.cc

diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc

index f1d0e18eb0b0e61132df54ae8a9c383f6c6bc684..c567864266ba85cf1dadcd51d12ddfd39083e0a5 100644

--- a/chromeos/dbus/fake_shill_device_client.cc

+++ b/chromeos/dbus/fake_shill_device_client.cc

@@ -266,7 +266,7 @@ void FakeShillDeviceClient::SetCarrier(const dbus::ObjectPath& device_path,

const base::Closure& callback,

const ErrorCallback& error_callback) {

SetPropertyInternal(device_path, shill::kCarrierProperty,

- base::StringValue(carrier), callback, error_callback);

+ base::Value(carrier), callback, error_callback);

}

void FakeShillDeviceClient::Reset(const dbus::ObjectPath& device_path,