Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/custom_handlers/protocol_handler.cc ('k') | chrome/common/extensions/sync_type_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index 8c9774498ddf1e21ae3324347f1cb877b6f271fa..747bf8a4f14221671a64a1bd5a0bb303ba4a70f9 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -114,8 +114,7 @@ TEST_F(ManifestUnitTest, Extension) {
std::unique_ptr<Manifest> manifest2(manifest->DeepCopy());
EXPECT_TRUE(manifest->Equals(manifest2.get()));
EXPECT_TRUE(manifest2->Equals(manifest.get()));
- MutateManifest(
- &manifest, "foo", new base::StringValue("blah"));
+ MutateManifest(&manifest, "foo", new base::Value("blah"));
EXPECT_FALSE(manifest->Equals(manifest2.get()));
}
@@ -168,8 +167,7 @@ TEST_F(ManifestUnitTest, ExtensionTypes) {
AssertType(manifest.get(), Manifest::TYPE_HOSTED_APP);
MutateManifest(
&manifest, keys::kWebURLs, NULL);
- MutateManifest(
- &manifest, keys::kLaunchWebURL, new base::StringValue("foo"));
+ MutateManifest(&manifest, keys::kLaunchWebURL, new base::Value("foo"));
AssertType(manifest.get(), Manifest::TYPE_HOSTED_APP);
MutateManifest(
&manifest, keys::kLaunchWebURL, NULL);
« no previous file with comments | « chrome/common/custom_handlers/protocol_handler.cc ('k') | chrome/common/extensions/sync_type_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698