chrome/browser/ui/webui/device_log_ui.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/device_log_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/device_log_ui.cc

diff --git a/chrome/browser/ui/webui/device_log_ui.cc b/chrome/browser/ui/webui/device_log_ui.cc

index 915f932167c197b9ec90041a90a8164f1833d40f..aead87768628266e570ba566f7cc617c0ceab637 100644

--- a/chrome/browser/ui/webui/device_log_ui.cc

+++ b/chrome/browser/ui/webui/device_log_ui.cc

@@ -38,7 +38,7 @@ class DeviceLogMessageHandler : public content::WebUIMessageHandler {

private:

void GetLog(const base::ListValue* value) const {

- base::StringValue data(device_event_log::GetAsString(

+ base::Value data(device_event_log::GetAsString(

device_event_log::NEWEST_FIRST, "json", "",

device_event_log::LOG_LEVEL_DEBUG, 0));

web_ui()->CallJavascriptFunctionUnsafe("DeviceLogUI.getLogCallback", data);