Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/app_launcher_login_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/app_launcher_login_handler.cc
diff --git a/chrome/browser/ui/webui/app_launcher_login_handler.cc b/chrome/browser/ui/webui/app_launcher_login_handler.cc
index 25ea3be0a67c4cec644fbdd72bb70942715381a3..ee7a3f257a2c6f19ea0c0e43c99bffcb34116c36 100644
--- a/chrome/browser/ui/webui/app_launcher_login_handler.cc
+++ b/chrome/browser/ui/webui/app_launcher_login_handler.cc
@@ -220,9 +220,9 @@ void AppLauncherLoginHandler::UpdateLogin() {
#endif
}
- base::StringValue header_value(header);
- base::StringValue sub_header_value(sub_header);
- base::StringValue icon_url_value(icon_url);
+ base::Value header_value(header);
+ base::Value sub_header_value(sub_header);
+ base::Value icon_url_value(icon_url);
base::Value is_user_signed_in(!username.empty());
web_ui()->CallJavascriptFunctionUnsafe("ntp.updateLogin", header_value,
sub_header_value, icon_url_value,
« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698