Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/extensions/api/font_settings/font_settings_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/font_settings/font_settings_api.cc
diff --git a/chrome/browser/extensions/api/font_settings/font_settings_api.cc b/chrome/browser/extensions/api/font_settings/font_settings_api.cc
index 1d3420a82767c8d272d09974cb53cb0bbbfbcd81..0348527bcfdc729db74cc6f28aee6b1402ee5a8a 100644
--- a/chrome/browser/extensions/api/font_settings/font_settings_api.cc
+++ b/chrome/browser/extensions/api/font_settings/font_settings_api.cc
@@ -278,7 +278,7 @@ ExtensionFunction::ResponseAction FontSettingsSetFontFunction::Run() {
PreferenceAPI::Get(profile)->SetExtensionControlledPref(
extension_id(), pref_path, kExtensionPrefsScopeRegular,
- new base::StringValue(params->details.font_id));
+ new base::Value(params->details.font_id));
return RespondNow(NoArguments());
}
@@ -319,8 +319,8 @@ bool FontSettingsGetFontListFunction::CopyFontsToResult(
std::unique_ptr<base::DictionaryValue> font_name(
new base::DictionaryValue());
- font_name->Set(kFontIdKey, new base::StringValue(name));
- font_name->Set(kDisplayNameKey, new base::StringValue(localized_name));
+ font_name->Set(kFontIdKey, new base::Value(name));
+ font_name->Set(kDisplayNameKey, new base::Value(localized_name));
result->Append(std::move(font_name));
}
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | chrome/browser/extensions/api/gcm/gcm_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698