Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: content/common/common_param_traits_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | content/common/font_list_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/common_param_traits_unittest.cc
diff --git a/content/common/common_param_traits_unittest.cc b/content/common/common_param_traits_unittest.cc
index 4756e22b50b224d59813f0192fe70c5a432485ea..c5acf22ac2f080e9fd6916ffd7efcb6dbcf41ce1 100644
--- a/content/common/common_param_traits_unittest.cc
+++ b/content/common/common_param_traits_unittest.cc
@@ -83,7 +83,7 @@ TEST(IPCMessageTest, Bitmap) {
TEST(IPCMessageTest, ListValue) {
base::ListValue input;
input.Set(0, new base::Value(42.42));
- input.Set(1, new base::StringValue("forty"));
+ input.Set(1, new base::Value("forty"));
input.Set(2, base::Value::CreateNullValue());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
@@ -109,13 +109,13 @@ TEST(IPCMessageTest, DictionaryValue) {
input.Set("int", new base::Value(42));
std::unique_ptr<base::DictionaryValue> subdict(new base::DictionaryValue());
- subdict->Set("str", new base::StringValue("forty two"));
+ subdict->Set("str", new base::Value("forty two"));
subdict->Set("bool", new base::Value(false));
std::unique_ptr<base::ListValue> sublist(new base::ListValue());
sublist->Set(0, new base::Value(42.42));
- sublist->Set(1, new base::StringValue("forty"));
- sublist->Set(2, new base::StringValue("two"));
+ sublist->Set(1, new base::Value("forty"));
+ sublist->Set(2, new base::Value("two"));
subdict->Set("list", sublist.release());
input.Set("dict", subdict.release());
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | content/common/font_list_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698