chrome/browser/task_profiler/task_profiler_data_serializer.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_profiler/task_profiler_data_serializer.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/task_profiler/task_profiler_data_serializer.cc

diff --git a/chrome/browser/task_profiler/task_profiler_data_serializer.cc b/chrome/browser/task_profiler/task_profiler_data_serializer.cc

index 6f4b52ee948b7368ac23902116ec48cea5d14bb9..ffc07fc96fdf73f35ee9c7a17893636c2304a74b 100644

--- a/chrome/browser/task_profiler/task_profiler_data_serializer.cc

+++ b/chrome/browser/task_profiler/task_profiler_data_serializer.cc

@@ -52,7 +52,7 @@ void BirthOnThreadSnapshotToValue(const BirthOnThreadSnapshot& birth,

dictionary->Set(prefix + "_location", location_value.release());

dictionary->Set(prefix + "_thread",

- new base::StringValue(birth.sanitized_thread_name));

+ new base::Value(birth.sanitized_thread_name));

}

// Re-serializes the |death_data| into |dictionary|.