Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index 5dc36adfd40f5339ad776513c6b0bbcf4ff8a1f0..38cf69ee7dfa4337bed43e5d821a4a4a19c7b574 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -527,20 +527,20 @@ ExtensionActionSetBadgeBackgroundColorFunction::RunExtensionAction() {
ExtensionFunction::ResponseAction
ExtensionActionGetTitleFunction::RunExtensionAction() {
- return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(
- extension_action_->GetTitle(tab_id_))));
+ return RespondNow(OneArgument(
+ base::MakeUnique<base::Value>(extension_action_->GetTitle(tab_id_))));
}
ExtensionFunction::ResponseAction
ExtensionActionGetPopupFunction::RunExtensionAction() {
- return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(
+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(
extension_action_->GetPopupUrl(tab_id_).spec())));
}
ExtensionFunction::ResponseAction
ExtensionActionGetBadgeTextFunction::RunExtensionAction() {
- return RespondNow(OneArgument(base::MakeUnique<base::StringValue>(
- extension_action_->GetBadgeText(tab_id_))));
+ return RespondNow(OneArgument(
+ base::MakeUnique<base::Value>(extension_action_->GetBadgeText(tab_id_))));
}
ExtensionFunction::ResponseAction

Powered by Google App Engine
This is Rietveld 408576698