Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
index eb1632f35829fdea83b371eb1f60634de984ded4..e410d1688ebcb9e97d24c7b20de6ae1442064b26 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
@@ -547,7 +547,7 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) {
{
ListPrefUpdate update(profile()->GetPrefs(),
prefs::kMediaRouterTabMirroringSources);
- update->AppendIfNotPresent(base::MakeUnique<base::StringValue>(origin));
+ update->AppendIfNotPresent(base::MakeUnique<base::Value>(origin));
}
// Auto-join requests should be rejected.
@@ -567,7 +567,7 @@ TEST_F(PresentationServiceDelegateImplTest, AutoJoinRequest) {
{
ListPrefUpdate update(profile()->GetPrefs(),
prefs::kMediaRouterTabMirroringSources);
- update->Remove(base::StringValue(origin), nullptr);
+ update->Remove(base::Value(origin), nullptr);
}
// Auto-join requests should now go through.
@@ -597,14 +597,14 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) {
{
ListPrefUpdate update(profile()->GetOffTheRecordProfile()->GetPrefs(),
prefs::kMediaRouterTabMirroringSources);
- update->AppendIfNotPresent(base::MakeUnique<base::StringValue>(origin));
+ update->AppendIfNotPresent(base::MakeUnique<base::Value>(origin));
}
// Setting the pref in incognito shouldn't set it for the non-incognito
// profile.
const base::ListValue* non_incognito_origins =
profile()->GetPrefs()->GetList(prefs::kMediaRouterTabMirroringSources);
- EXPECT_EQ(non_incognito_origins->Find(base::StringValue(origin)),
+ EXPECT_EQ(non_incognito_origins->Find(base::Value(origin)),
non_incognito_origins->end());
// Auto-join requests should be rejected.
@@ -624,7 +624,7 @@ TEST_F(PresentationServiceDelegateImplIncognitoTest, AutoJoinRequest) {
{
ListPrefUpdate update(profile()->GetOffTheRecordProfile()->GetPrefs(),
prefs::kMediaRouterTabMirroringSources);
- update->Remove(base::StringValue(origin), nullptr);
+ update->Remove(base::Value(origin), nullptr);
}
// Auto-join requests should now go through.
« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/net/disk_cache_dir_policy_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698