Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index 90111f15e997c6dcb2f635d48936f91f3b19537c..b20157e3917d9e159c2c6dcab82ccfb7bbe3b7cc 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -941,7 +941,7 @@ bool FileManagerPrivateRequestAccessTokenFunction::RunAsync() {
if (!drive_service) {
// DriveService is not available.
- SetResult(base::MakeUnique<base::StringValue>(std::string()));
+ SetResult(base::MakeUnique<base::Value>(std::string()));
SendResponse(true);
return true;
}
@@ -961,7 +961,7 @@ bool FileManagerPrivateRequestAccessTokenFunction::RunAsync() {
void FileManagerPrivateRequestAccessTokenFunction::OnAccessTokenFetched(
google_apis::DriveApiErrorCode code,
const std::string& access_token) {
- SetResult(base::MakeUnique<base::StringValue>(access_token));
+ SetResult(base::MakeUnique<base::Value>(access_token));
SendResponse(true);
}
@@ -1000,7 +1000,7 @@ void FileManagerPrivateInternalGetShareUrlFunction::OnGetShareUrl(
return;
}
- SetResult(base::MakeUnique<base::StringValue>(share_url.spec()));
+ SetResult(base::MakeUnique<base::Value>(share_url.spec()));
SendResponse(true);
}
@@ -1078,7 +1078,7 @@ bool FileManagerPrivateInternalGetDownloadUrlFunction::RunAsync() {
// |file_system| is NULL if Drive is disabled or not mounted.
SetError("Drive is disabled or not mounted.");
// Intentionally returns a blank.
- SetResult(base::MakeUnique<base::StringValue>(std::string()));
+ SetResult(base::MakeUnique<base::Value>(std::string()));
return false;
}
@@ -1087,7 +1087,7 @@ bool FileManagerPrivateInternalGetDownloadUrlFunction::RunAsync() {
if (!drive::util::IsUnderDriveMountPoint(path)) {
SetError("The given file is not in Drive.");
// Intentionally returns a blank.
- SetResult(base::MakeUnique<base::StringValue>(std::string()));
+ SetResult(base::MakeUnique<base::Value>(std::string()));
return false;
}
base::FilePath file_path = drive::util::ExtractDrivePath(path);
@@ -1108,7 +1108,7 @@ void FileManagerPrivateInternalGetDownloadUrlFunction::OnGetResourceEntry(
if (error != drive::FILE_ERROR_OK) {
SetError("Download Url for this item is not available.");
// Intentionally returns a blank.
- SetResult(base::MakeUnique<base::StringValue>(std::string()));
+ SetResult(base::MakeUnique<base::Value>(std::string()));
SendResponse(false);
return;
}
@@ -1143,14 +1143,14 @@ void FileManagerPrivateInternalGetDownloadUrlFunction::OnTokenFetched(
if (code != google_apis::HTTP_SUCCESS) {
SetError("Not able to fetch the token.");
// Intentionally returns a blank.
- SetResult(base::MakeUnique<base::StringValue>(std::string()));
+ SetResult(base::MakeUnique<base::Value>(std::string()));
SendResponse(false);
return;
}
const std::string url =
download_url_.Resolve("?alt=media&access_token=" + access_token).spec();
- SetResult(base::MakeUnique<base::StringValue>(url));
+ SetResult(base::MakeUnique<base::Value>(url));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698