components/policy/core/common/preg_parser_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/preg_parser_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/preg_parser_unittest.cc

diff --git a/components/policy/core/common/preg_parser_unittest.cc b/components/policy/core/common/preg_parser_unittest.cc

index e29c9c4b530b4136db9b5763e114b583e2d4614b..757ac70e62ef13b65ba266688a3042098cb3651f 100644

--- a/components/policy/core/common/preg_parser_unittest.cc

+++ b/components/policy/core/common/preg_parser_unittest.cc

@@ -66,8 +66,7 @@ void SetInteger(RegistryDict* dict,

void SetString(RegistryDict* dict,

const std::string& name,

const std::string& value) {

- dict->SetValue(name,

- base::WrapUnique<base::Value>(new base::StringValue(value)));

+ dict->SetValue(name, base::WrapUnique<base::Value>(new base::Value(value)));

}

TEST(PRegParserTest, TestParseFile) {