Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/desc_builder.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/ipc_fuzzer/fuzzer/fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/desc_builder.cc
diff --git a/tools/gn/desc_builder.cc b/tools/gn/desc_builder.cc
index a1a5710fc12eac1817010698cfc9861af87a3aa2..c04fad6d18170aaecebcfeb1e1164adda303aefa 100644
--- a/tools/gn/desc_builder.cc
+++ b/tools/gn/desc_builder.cc
@@ -123,17 +123,17 @@ class BaseDescBuilder {
ValuePtr RenderValue(const std::string& s, bool optional = false) {
return (s.empty() && optional) ? base::Value::CreateNullValue()
- : ValuePtr(new base::StringValue(s));
+ : ValuePtr(new base::Value(s));
}
ValuePtr RenderValue(const SourceDir& d) {
return d.is_null() ? base::Value::CreateNullValue()
- : ValuePtr(new base::StringValue(FormatSourceDir(d)));
+ : ValuePtr(new base::Value(FormatSourceDir(d)));
}
ValuePtr RenderValue(const SourceFile& f) {
return f.is_null() ? base::Value::CreateNullValue()
- : ValuePtr(new base::StringValue(f.value()));
+ : ValuePtr(new base::Value(f.value()));
}
ValuePtr RenderValue(const LibFile& lib) {
@@ -679,7 +679,7 @@ class TargetDescBuilder : public BaseDescBuilder {
// Indent string values in blame mode
if (blame_ && rendered->GetAsString(&str)) {
str = " " + str;
- rendered = base::MakeUnique<base::StringValue>(str);
+ rendered = base::MakeUnique<base::Value>(str);
}
res->Append(std::move(rendered));
}
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/ipc_fuzzer/fuzzer/fuzzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698