components/policy/core/common/policy_loader_mac_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_loader_mac_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/policy_loader_mac_unittest.cc

diff --git a/components/policy/core/common/policy_loader_mac_unittest.cc b/components/policy/core/common/policy_loader_mac_unittest.cc

index 7f3c14fa94949e6fd254d66ce9a3eeb1d709c0c2..a9d636fc0735b32e64b029efcaf2fc69cc815f57 100644

--- a/components/policy/core/common/policy_loader_mac_unittest.cc

+++ b/components/policy/core/common/policy_loader_mac_unittest.cc

@@ -199,7 +199,7 @@ TEST_F(PolicyLoaderMacTest, TestNonForcedValue) {

expected_bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

.Set(test_keys::kKeyString, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,

POLICY_SOURCE_PLATFORM,

- base::MakeUnique<base::StringValue>("string value"), nullptr);

+ base::MakeUnique<base::Value>("string value"), nullptr);

EXPECT_TRUE(provider_->policies().Equals(expected_bundle));

}