Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6417)

Unified Diff: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
diff --git a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
index a1bde6844bb5ec49e779cecfd1fe2270551b27bf..e6123b8836b63f50af977db1b09381f3fdec7899 100644
--- a/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
+++ b/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
@@ -358,7 +358,7 @@ TEST_F(NetworkConfigurationUpdaterTest, PolicyIsValidatedAndRepaired) {
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>(onc_policy), nullptr);
+ base::MakeUnique<base::Value>(onc_policy), nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -479,7 +479,7 @@ TEST_F(NetworkConfigurationUpdaterTest,
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>(kFakeONC), nullptr);
+ base::MakeUnique<base::Value>(kFakeONC), nullptr);
UpdateProviderPolicy(policy);
base::RunLoop().RunUntilIdle();
@@ -500,7 +500,7 @@ TEST_F(NetworkConfigurationUpdaterTest,
PolicyMap policy;
policy.Set(key::kOpenNetworkConfiguration, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>(kFakeONC), nullptr);
+ base::MakeUnique<base::Value>(kFakeONC), nullptr);
UpdateProviderPolicy(policy);
EXPECT_CALL(network_config_handler_,
@@ -567,7 +567,7 @@ class NetworkConfigurationUpdaterTestWithParam
TEST_P(NetworkConfigurationUpdaterTestWithParam, InitialUpdates) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(kFakeONC),
nullptr);
UpdateProviderPolicy(policy);
@@ -589,7 +589,7 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam,
PolicyNotSetBeforePolicyProviderInitialized) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(kFakeONC),
nullptr);
UpdateProviderPolicy(policy);
@@ -617,7 +617,7 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam,
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(kFakeONC),
nullptr);
UpdateProviderPolicy(policy);
@@ -657,7 +657,7 @@ TEST_P(NetworkConfigurationUpdaterTestWithParam, PolicyChange) {
PolicyMap policy;
policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>(kFakeONC),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(kFakeONC),
nullptr);
UpdateProviderPolicy(policy);
Mock::VerifyAndClearExpectations(&network_config_handler_);

Powered by Google App Engine
This is Rietveld 408576698