Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/clang/value_cleanup/ListValueRewriter.cpp

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/value_cleanup/ListValueRewriter.cpp
diff --git a/tools/clang/value_cleanup/ListValueRewriter.cpp b/tools/clang/value_cleanup/ListValueRewriter.cpp
index 85b1d28b8e07d9e27a6c5e21614f1b85c3ac3e34..67988b5fba72bcf3f40f19d6d988b07e318070a0 100644
--- a/tools/clang/value_cleanup/ListValueRewriter.cpp
+++ b/tools/clang/value_cleanup/ListValueRewriter.cpp
@@ -408,20 +408,20 @@ void ListValueRewriter::RegisterMatchers(MatchFinder* match_finder) {
realFloatingPointType())))))))))))),
&append_double_callback_);
- // base::ListValue::Append(new base::StringValue(...))
+ // base::ListValue::Append(new base::Value(...))
// => base::ListValue::AppendString()
match_finder->addMatcher(
id("callExpr",
cxxMemberCallExpr(
is_list_append,
hasArgument(
- 0, ignoringParenImpCasts(id(
- "newExpr",
- cxxNewExpr(has(cxxConstructExpr(
- hasDeclaration(cxxMethodDecl(
- hasName("::base::StringValue::StringValue"))),
- argumentCountIs(1),
- hasArgument(0, id("argExpr", expr())))))))))),
+ 0, ignoringParenImpCasts(
+ id("newExpr",
+ cxxNewExpr(has(cxxConstructExpr(
+ hasDeclaration(cxxMethodDecl(
+ hasName("::base::Value::StringValue"))),
+ argumentCountIs(1),
+ hasArgument(0, id("argExpr", expr())))))))))),
&append_string_callback_);
auto is_unique_ptr_release =

Powered by Google App Engine
This is Rietveld 408576698