ios/web/web_state/ui/web_view_js_utils.mm - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/web_view_js_utils.mm

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/web_view_js_utils.mm

diff --git a/ios/web/web_state/ui/web_view_js_utils.mm b/ios/web/web_state/ui/web_view_js_utils.mm

index 50e4f42b1365126da8e1fe0782d1490349968fd4..b7aade3225a1371e29a1eb1c7967d6d6c3b3a5a9 100644

--- a/ios/web/web_state/ui/web_view_js_utils.mm

+++ b/ios/web/web_state/ui/web_view_js_utils.mm

@@ -32,7 +32,7 @@ std::unique_ptr<base::Value> ValueResultFromWKResult(id wk_result,

CFTypeID result_type = CFGetTypeID(wk_result);

if (result_type == CFStringGetTypeID()) {

- result.reset(new base::StringValue(base::SysNSStringToUTF16(wk_result)));

+ result.reset(new base::Value(base::SysNSStringToUTF16(wk_result)));

DCHECK(result->IsType(base::Value::Type::STRING));

} else if (result_type == CFNumberGetTypeID()) {

result.reset(new base::Value([wk_result doubleValue]));