Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index ccd13f8af48559c88cf81b3e4fcc7c16b22936fb..242f8eeb9dc7a2725fcbe6e72fc525a0b7b68b68 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -979,7 +979,7 @@ void DeveloperPrivateLoadDirectoryFunction::Load() {
// TODO(grv) : The unpacked installer should fire an event when complete
// and return the extension_id.
- SetResult(base::MakeUnique<base::StringValue>("-1"));
+ SetResult(base::MakeUnique<base::Value>("-1"));
SendResponse(true);
}
@@ -1153,8 +1153,7 @@ ExtensionFunction::ResponseAction DeveloperPrivateChoosePathFunction::Run() {
void DeveloperPrivateChoosePathFunction::FileSelected(
const base::FilePath& path) {
- Respond(OneArgument(
- base::MakeUnique<base::StringValue>(path.LossyDisplayName())));
+ Respond(OneArgument(base::MakeUnique<base::Value>(path.LossyDisplayName())));
Release();
}

Powered by Google App Engine
This is Rietveld 408576698