chrome/test/chromedriver/alert_commands.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/alert_commands.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/alert_commands.cc

diff --git a/chrome/test/chromedriver/alert_commands.cc b/chrome/test/chromedriver/alert_commands.cc

index 9910dd771c285715fde085f2da8e5fb9ae84bfa1..682ab962b330a1cfbf0d020dce460de8f7ff888d 100644

--- a/chrome/test/chromedriver/alert_commands.cc

+++ b/chrome/test/chromedriver/alert_commands.cc

@@ -57,7 +57,7 @@ Status ExecuteGetAlertText(Session* session,

web_view->GetJavaScriptDialogManager()->GetDialogMessage(&message);

if (status.IsError())

return status;

- value->reset(new base::StringValue(message));

+ value->reset(new base::Value(message));

return Status(kOk);

}