chrome/browser/component_updater/supervised_user_whitelist_installer.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/origin_trials_component_installer_unittest.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/supervised_user_whitelist_installer.cc

diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

index d0e79cc75ef8cf49232563042cf1ae2ad670a5f1..73e0a94e43e3dfa36f5ae86b4377ab7f79cd9359 100644

--- a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

@@ -439,7 +439,7 @@ bool SupervisedUserWhitelistInstallerImpl::UnregisterWhitelistInternal(

base::ListValue* clients = nullptr;

success = whitelist_dict->GetList(kClients, &clients);

- const bool removed = clients->Remove(base::StringValue(client_id), nullptr);

+ const bool removed = clients->Remove(base::Value(client_id), nullptr);

if (!clients->empty())

return removed;

@@ -549,8 +549,8 @@ void SupervisedUserWhitelistInstallerImpl::RegisterWhitelist(

clients = new base::ListValue;

whitelist_dict->Set(kClients, clients);

}

- bool success = clients->AppendIfNotPresent(

- base::MakeUnique<base::StringValue>(client_id));

+ bool success =

+ clients->AppendIfNotPresent(base::MakeUnique<base::Value>(client_id));

DCHECK(success);

}