Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3076)

Unified Diff: chrome/browser/chromeos/settings/cros_settings_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings_unittest.cc b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
index 52810636025970127c459e2beb5eb332fb9c654d..da1dc1ddde298f70ddb5c1639dd88dfef5a15eba 100644
--- a/chrome/browser/chromeos/settings/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
@@ -133,7 +133,7 @@ TEST_F(CrosSettingsTest, SetWhitelist) {
TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
std::unique_ptr<base::ListValue> whitelist =
base::MakeUnique<base::ListValue>();
- base::StringValue hacky_user("h@xxor");
+ base::Value hacky_user("h@xxor");
whitelist->Append(hacky_user.CreateDeepCopy());
AddExpectation(kAccountsPrefAllowNewUser,
base::MakeUnique<base::Value>(false));
@@ -146,8 +146,8 @@ TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
TEST_F(CrosSettingsTest, SetWhitelistWithListOps2) {
base::ListValue whitelist;
- base::StringValue hacky_user("h@xxor");
- base::StringValue lamy_user("l@mer");
+ base::Value hacky_user("h@xxor");
+ base::Value lamy_user("l@mer");
whitelist.Append(hacky_user.CreateDeepCopy());
std::unique_ptr<base::ListValue> expected_list = whitelist.CreateDeepCopy();
whitelist.Append(lamy_user.CreateDeepCopy());

Powered by Google App Engine
This is Rietveld 408576698