Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7100)

Unified Diff: chrome/browser/ui/webui/inspect_ui_browsertest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.cc ('k') | chrome/browser/ui/webui/instant_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/inspect_ui_browsertest.cc b/chrome/browser/ui/webui/inspect_ui_browsertest.cc
index e0c14b58309b5489225eabfd9d90e169937c7bec..2d9d40649bca72f2e119527dd223d5b2eab98b3a 100644
--- a/chrome/browser/ui/webui/inspect_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/inspect_ui_browsertest.cc
@@ -39,10 +39,9 @@ class InspectUITest : public WebUIBrowserTest {
IN_PROC_BROWSER_TEST_F(InspectUITest, InspectUIPage) {
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIInspectURL));
ASSERT_TRUE(WebUIBrowserTest::RunJavascriptAsyncTest(
- "testTargetListed",
- new base::StringValue("#pages"),
- new base::StringValue("populateWebContentsTargets"),
- new base::StringValue(chrome::kChromeUIInspectURL)));
+ "testTargetListed", new base::Value("#pages"),
+ new base::Value("populateWebContentsTargets"),
+ new base::Value(chrome::kChromeUIInspectURL)));
}
IN_PROC_BROWSER_TEST_F(InspectUITest, SharedWorker) {
@@ -56,16 +55,14 @@ IN_PROC_BROWSER_TEST_F(InspectUITest, SharedWorker) {
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
ASSERT_TRUE(WebUIBrowserTest::RunJavascriptAsyncTest(
- "testTargetListed",
- new base::StringValue("#workers"),
- new base::StringValue("populateWorkerTargets"),
- new base::StringValue(kSharedWorkerJs)));
+ "testTargetListed", new base::Value("#workers"),
+ new base::Value("populateWorkerTargets"),
+ new base::Value(kSharedWorkerJs)));
ASSERT_TRUE(WebUIBrowserTest::RunJavascriptAsyncTest(
- "testTargetListed",
- new base::StringValue("#pages"),
- new base::StringValue("populateWebContentsTargets"),
- new base::StringValue(kSharedWorkerTestPage)));
+ "testTargetListed", new base::Value("#pages"),
+ new base::Value("populateWebContentsTargets"),
+ new base::Value(kSharedWorkerTestPage)));
}
// Flaky due to failure to bind a hardcoded port. crbug.com/566057
« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.cc ('k') | chrome/browser/ui/webui/instant_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698