Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: mojo/common/values_struct_traits.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/common_custom_types_unittest.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/values_struct_traits.cc
diff --git a/mojo/common/values_struct_traits.cc b/mojo/common/values_struct_traits.cc
index 9c5df7ab61ecd171a338fc1c7688c3cf3d62210a..6af7a395338804f1c9b8b0eda06ee5ee8ca403d0 100644
--- a/mojo/common/values_struct_traits.cc
+++ b/mojo/common/values_struct_traits.cc
@@ -77,7 +77,7 @@ bool UnionTraits<common::mojom::ValueDataView, std::unique_ptr<base::Value>>::
base::StringPiece string_value;
if (!data.ReadStringValue(&string_value))
return false;
- *value_out = base::MakeUnique<base::StringValue>(string_value);
+ *value_out = base::MakeUnique<base::Value>(string_value);
return true;
}
case common::mojom::ValueDataView::Tag::BINARY_VALUE: {
« no previous file with comments | « mojo/common/common_custom_types_unittest.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698