Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Side by Side Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h" 5 #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 ExtensionBuilder() 504 ExtensionBuilder()
505 .SetManifest(DictionaryBuilder() 505 .SetManifest(DictionaryBuilder()
506 .Set("name", "Test extension") 506 .Set("name", "Test extension")
507 .Set("version", "1.0.0") 507 .Set("version", "1.0.0")
508 .Set("manifest_version", 2) 508 .Set("manifest_version", 2)
509 .Build()) 509 .Build())
510 .Build(); 510 .Build();
511 extension_service_->AddExtension(extension.get()); 511 extension_service_->AddExtension(extension.get());
512 512
513 std::unique_ptr<base::ListValue> args(new base::ListValue()); 513 std::unique_ptr<base::ListValue> args(new base::ListValue());
514 args->Set(0, new base::StringValue("hello")); 514 args->Set(0, new base::Value("hello"));
515 args->Set(1, new base::StringValue("world")); 515 args->Set(1, new base::Value("world"));
516 scoped_refptr<Action> action = new Action(extension->id(), 516 scoped_refptr<Action> action = new Action(extension->id(),
517 base::Time::Now(), 517 base::Time::Now(),
518 Action::ACTION_API_CALL, 518 Action::ACTION_API_CALL,
519 "extension.connect"); 519 "extension.connect");
520 action->set_args(std::move(args)); 520 action->set_args(std::move(args));
521 521
522 policy->ProcessAction(action); 522 policy->ProcessAction(action);
523 CheckReadData(policy, 523 CheckReadData(policy,
524 extension->id(), 524 extension->id(),
525 0, 525 0,
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 action_ids.push_back(3); 940 action_ids.push_back(3);
941 action_ids.push_back(4); 941 action_ids.push_back(4);
942 CheckRemoveActions( 942 CheckRemoveActions(
943 policy, action_ids, base::Bind(&FullStreamUIPolicyTest::Action2Deleted)); 943 policy, action_ids, base::Bind(&FullStreamUIPolicyTest::Action2Deleted));
944 action_ids.clear(); 944 action_ids.clear();
945 945
946 policy->Close(); 946 policy->Close();
947 } 947 }
948 948
949 } // namespace extensions 949 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698