extensions/browser/api/app_window/app_window_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_window/app_window_api.cc

diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc

index 10d91fbdd1084e1c08d2d20b1973ab51464980ab..56e00d591f77f6b3a4b944fb8b88bcab7b9f46e2 100644

--- a/extensions/browser/api/app_window/app_window_api.cc

+++ b/extensions/browser/api/app_window/app_window_api.cc

@@ -382,7 +382,7 @@ bool AppWindowCreateFunction::RunAsync() {

std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);

result->Set("frameId", new base::Value(frame_id));

- result->Set("id", new base::StringValue(app_window->window_key()));

+ result->Set("id", new base::Value(app_window->window_key()));

app_window->GetSerializedState(result.get());

SetResult(std::move(result));