Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: rlz/chromeos/lib/rlz_value_store_chromeos.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/spawned_test_server/base_test_server.cc ('k') | services/catalog/public/tools/catalog.cc.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/chromeos/lib/rlz_value_store_chromeos.cc
diff --git a/rlz/chromeos/lib/rlz_value_store_chromeos.cc b/rlz/chromeos/lib/rlz_value_store_chromeos.cc
index 84167aa6a08c0cfd5cae6d8d51d763f2d57e1252..6c72bff7cb2c8ea2ce9ab4a84a078747d0456062 100644
--- a/rlz/chromeos/lib/rlz_value_store_chromeos.cc
+++ b/rlz/chromeos/lib/rlz_value_store_chromeos.cc
@@ -148,7 +148,7 @@ bool RlzValueStoreChromeOS::AddProductEvent(Product product,
const char* event_rlz) {
DCHECK(CalledOnValidThread());
return AddValueToList(GetKeyName(kProductEventKey, product),
- base::MakeUnique<base::StringValue>(event_rlz));
+ base::MakeUnique<base::Value>(event_rlz));
}
bool RlzValueStoreChromeOS::ReadProductEvents(
@@ -170,7 +170,7 @@ bool RlzValueStoreChromeOS::ReadProductEvents(
bool RlzValueStoreChromeOS::ClearProductEvent(Product product,
const char* event_rlz) {
DCHECK(CalledOnValidThread());
- base::StringValue event_value(event_rlz);
+ base::Value event_value(event_rlz);
return RemoveValueFromList(GetKeyName(kProductEventKey, product),
event_value);
}
@@ -185,13 +185,13 @@ bool RlzValueStoreChromeOS::AddStatefulEvent(Product product,
const char* event_rlz) {
DCHECK(CalledOnValidThread());
return AddValueToList(GetKeyName(kStatefulEventKey, product),
- base::MakeUnique<base::StringValue>(event_rlz));
+ base::MakeUnique<base::Value>(event_rlz));
}
bool RlzValueStoreChromeOS::IsStatefulEvent(Product product,
const char* event_rlz) {
DCHECK(CalledOnValidThread());
- base::StringValue event_value(event_rlz);
+ base::Value event_value(event_rlz);
base::ListValue* events_list = NULL;
return rlz_store_->GetList(GetKeyName(kStatefulEventKey, product),
&events_list) &&
« no previous file with comments | « net/test/spawned_test_server/base_test_server.cc ('k') | services/catalog/public/tools/catalog.cc.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698