extensions/common/url_pattern_set.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern_set.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/url_pattern_set.cc

diff --git a/extensions/common/url_pattern_set.cc b/extensions/common/url_pattern_set.cc

index 56860926fb455c5295d5b99f9cc61d5ab97241a3..28c8cf70a5f639862004ee7c10962502f1adbe2f 100644

--- a/extensions/common/url_pattern_set.cc

+++ b/extensions/common/url_pattern_set.cc

@@ -233,8 +233,7 @@ std::unique_ptr<base::ListValue> URLPatternSet::ToValue() const {

std::unique_ptr<base::ListValue> value(new base::ListValue);

for (URLPatternSet::const_iterator i = patterns_.begin();

i != patterns_.end(); ++i)

- value->AppendIfNotPresent(

- base::MakeUnique<base::StringValue>(i->GetAsString()));

+ value->AppendIfNotPresent(base::MakeUnique<base::Value>(i->GetAsString()));

return value;

}