chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc ('k') | chrome/browser/chromeos/net/network_state_notifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

index 9cc0a2428bfa9e53435dc5ee90d5705141a57f90..daba966fdab2016e621979b1218cba1dea264df1 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

@@ -233,10 +233,8 @@ class NetworkPortalDetectorImplTest

void SetBehindPortal(const std::string& service_path) {

DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(

- dbus::ObjectPath(service_path),

- shill::kStateProperty,

- base::StringValue(shill::kStatePortal),

- base::Bind(&base::DoNothing),

+ dbus::ObjectPath(service_path), shill::kStateProperty,

+ base::Value(shill::kStatePortal), base::Bind(&base::DoNothing),

base::Bind(&ErrorCallbackFunction));

base::RunLoop().RunUntilIdle();

}