Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5515)

Unified Diff: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
index d2d0b0ec5e5452cd3d57efd1805cd5cf8a068880..fef6e14c4d2bed903c4d19636e1cfa25844bb3d1 100644
--- a/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
@@ -108,8 +108,7 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
args.SetInteger(kStart, start);
args.Set(kChildren, std::move(children));
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("onTreeItemAdded"),
- args);
+ base::Value("onTreeItemAdded"), args);
}
void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
@@ -130,8 +129,7 @@ void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
args.SetInteger(kStart, start);
args.SetInteger(kCount, count);
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("onTreeItemRemoved"),
- args);
+ base::Value("onTreeItemRemoved"), args);
}
void CookiesViewHandler::TreeModelBeginBatch(CookiesTreeModel* model) {
@@ -199,7 +197,7 @@ void CookiesViewHandler::HandleGetCookieDetails(const base::ListValue* args) {
cookies_tree_model_->GetRoot(), base::UTF8ToUTF16(site));
if (!node) {
- RejectJavascriptCallback(base::StringValue(callback_id_),
+ RejectJavascriptCallback(base::Value(callback_id_),
*base::Value::CreateNullValue());
callback_id_.clear();
return;
@@ -262,7 +260,7 @@ void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
args.SetString(kId, model_util_->GetTreeNodeId(parent));
args.Set(kChildren, std::move(children));
- ResolveJavascriptCallback(base::StringValue(callback_id_), args);
+ ResolveJavascriptCallback(base::Value(callback_id_), args);
callback_id_.clear();
}
@@ -282,7 +280,7 @@ void CookiesViewHandler::SendCookieDetails(const CookieTreeNode* parent) {
args.SetString(kId, model_util_->GetTreeNodeId(parent));
args.Set(kChildren, std::move(children));
- ResolveJavascriptCallback(base::StringValue(callback_id_), args);
+ ResolveJavascriptCallback(base::Value(callback_id_), args);
callback_id_.clear();
}

Powered by Google App Engine
This is Rietveld 408576698