Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl_unittest.cc
diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc
index 83bf27e917b6048aa5c16754e8cd43a998fe0d22..2997770e8239095678e1a733f787b4e8574eb4c1 100644
--- a/content/child/v8_value_converter_impl_unittest.cc
+++ b/content/child/v8_value_converter_impl_unittest.cc
@@ -418,7 +418,7 @@ TEST_F(V8ValueConverterImplTest, WeirdTypes) {
converter.SetRegExpAllowed(true);
TestWeirdType(converter, regex, base::Value::Type::STRING,
- std::unique_ptr<base::Value>(new base::StringValue("/./")));
+ std::unique_ptr<base::Value>(new base::Value("/./")));
}
TEST_F(V8ValueConverterImplTest, Prototype) {
@@ -1021,7 +1021,7 @@ class V8ValueConverterOverridingStrategyForTesting
private:
static std::unique_ptr<base::Value> NewReferenceValue() {
- return base::MakeUnique<base::StringValue>("strategy");
+ return base::MakeUnique<base::Value>("strategy");
}
std::unique_ptr<base::Value> reference_value_;
};
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698