Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4270)

Unified Diff: chrome/common/custom_handlers/protocol_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/welcome_win10_handler.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/custom_handlers/protocol_handler.cc
diff --git a/chrome/common/custom_handlers/protocol_handler.cc b/chrome/common/custom_handlers/protocol_handler.cc
index 63f3d9ac3de007132c732daad82ff17c545c328b..0990f48d562eacc767e1c18760505b9c681f8055 100644
--- a/chrome/common/custom_handlers/protocol_handler.cc
+++ b/chrome/common/custom_handlers/protocol_handler.cc
@@ -61,8 +61,8 @@ GURL ProtocolHandler::TranslateUrl(const GURL& url) const {
std::unique_ptr<base::DictionaryValue> ProtocolHandler::Encode() const {
auto d = base::MakeUnique<base::DictionaryValue>();
- d->Set("protocol", new base::StringValue(protocol_));
- d->Set("url", new base::StringValue(url_.spec()));
+ d->Set("protocol", new base::Value(protocol_));
+ d->Set("url", new base::Value(url_.spec()));
return d;
}
« no previous file with comments | « chrome/browser/ui/webui/welcome_win10_handler.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698