chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc ('k') | chrome/browser/extensions/api/storage/policy_value_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

index 27173838be4831c2189b2ee33441abbb1e536c39..609163e45fc70c8247a9d871197e2756e1a80546 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

@@ -159,7 +159,7 @@ void SettingsOverridesAPI::OnExtensionLoaded(

ExtensionPrefs::Get(profile_)->GetInstallParam(extension->id());

if (settings->homepage) {

SetPref(extension->id(), prefs::kHomePage,

- base::MakeUnique<base::StringValue>(SubstituteInstallParam(

+ base::MakeUnique<base::Value>(SubstituteInstallParam(

settings->homepage->spec(), install_parameter)));

SetPref(extension->id(), prefs::kHomePageIsNewTabPage,

base::MakeUnique<base::Value>(false));