Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/ui/webui/version_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/version_handler.cc
diff --git a/chrome/browser/ui/webui/version_handler.cc b/chrome/browser/ui/webui/version_handler.cc
index b044d550915e55a0a860f79e6b96126225605503..3d7f7ba7e3b34d99ecd4d88dc43f4fd2d651a33d 100644
--- a/chrome/browser/ui/webui/version_handler.cc
+++ b/chrome/browser/ui/webui/version_handler.cc
@@ -97,8 +97,8 @@ void VersionHandler::OnGotFilePaths(base::string16* executable_path_data,
base::string16* profile_path_data) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- base::StringValue exec_path(*executable_path_data);
- base::StringValue profile_path(*profile_path_data);
+ base::Value exec_path(*executable_path_data);
+ base::Value profile_path(*profile_path_data);
web_ui()->CallJavascriptFunctionUnsafe(version_ui::kReturnFilePaths,
exec_path, profile_path);
}
@@ -125,7 +125,7 @@ void VersionHandler::OnGotPlugins(
}
}
- base::StringValue arg(flash_version_and_path);
+ base::Value arg(flash_version_and_path);
web_ui()->CallJavascriptFunctionUnsafe(version_ui::kReturnFlashVersion, arg);
}
« no previous file with comments | « chrome/browser/ui/webui/user_actions/user_actions_ui_handler.cc ('k') | chrome/browser/ui/webui/version_handler_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698