Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h" 5 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabled) { 239 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabled) {
240 TestCloudPrintProxyService service(&profile_); 240 TestCloudPrintProxyService service(&profile_);
241 241
242 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 242 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
243 MockServiceProcessControl::kServiceStateDisabled, false); 243 MockServiceProcessControl::kServiceStateDisabled, false);
244 244
245 sync_preferences::TestingPrefServiceSyncable* prefs = 245 sync_preferences::TestingPrefServiceSyncable* prefs =
246 profile_.GetTestingPrefService(); 246 profile_.GetTestingPrefService();
247 prefs->SetUserPref( 247 prefs->SetUserPref(
248 prefs::kCloudPrintEmail, 248 prefs::kCloudPrintEmail,
249 new base::StringValue(MockServiceProcessControl::EnabledUserId())); 249 new base::Value(MockServiceProcessControl::EnabledUserId()));
250 250
251 service.Initialize(); 251 service.Initialize();
252 252
253 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 253 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
254 } 254 }
255 255
256 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabled) { 256 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabled) {
257 TestCloudPrintProxyService service(&profile_); 257 TestCloudPrintProxyService service(&profile_);
258 258
259 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 259 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
260 MockServiceProcessControl::kServiceStateEnabled, false); 260 MockServiceProcessControl::kServiceStateEnabled, false);
261 261
262 sync_preferences::TestingPrefServiceSyncable* prefs = 262 sync_preferences::TestingPrefServiceSyncable* prefs =
263 profile_.GetTestingPrefService(); 263 profile_.GetTestingPrefService();
264 prefs->SetUserPref(prefs::kCloudPrintEmail, 264 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
265 new base::StringValue(std::string()));
266 265
267 service.Initialize(); 266 service.Initialize();
268 service.RefreshStatusFromService(); 267 service.RefreshStatusFromService();
269 268
270 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(), 269 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
271 prefs->GetString(prefs::kCloudPrintEmail)); 270 prefs->GetString(prefs::kCloudPrintEmail));
272 } 271 }
273 272
274 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) { 273 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {
275 TestCloudPrintProxyService service(&profile_); 274 TestCloudPrintProxyService service(&profile_);
276 275
277 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 276 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
278 MockServiceProcessControl::kServiceStateDisabled, false); 277 MockServiceProcessControl::kServiceStateDisabled, false);
279 278
280 sync_preferences::TestingPrefServiceSyncable* prefs = 279 sync_preferences::TestingPrefServiceSyncable* prefs =
281 profile_.GetTestingPrefService(); 280 profile_.GetTestingPrefService();
282 prefs->SetUserPref(prefs::kCloudPrintEmail, 281 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
283 new base::StringValue(std::string()));
284 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 282 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
285 283
286 service.Initialize(); 284 service.Initialize();
287 285
288 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 286 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
289 } 287 }
290 288
291 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) { 289 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {
292 TestCloudPrintProxyService service(&profile_); 290 TestCloudPrintProxyService service(&profile_);
293 291
294 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 292 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
295 MockServiceProcessControl::kServiceStateEnabled, false); 293 MockServiceProcessControl::kServiceStateEnabled, false);
296 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 294 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
297 295
298 sync_preferences::TestingPrefServiceSyncable* prefs = 296 sync_preferences::TestingPrefServiceSyncable* prefs =
299 profile_.GetTestingPrefService(); 297 profile_.GetTestingPrefService();
300 prefs->SetUserPref(prefs::kCloudPrintEmail, 298 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
301 new base::StringValue(std::string()));
302 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 299 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
303 300
304 service.Initialize(); 301 service.Initialize();
305 302
306 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 303 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
307 } 304 }
308 305
309 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) { 306 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {
310 TestCloudPrintProxyService service(&profile_); 307 TestCloudPrintProxyService service(&profile_);
311 308
312 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 309 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
313 MockServiceProcessControl::kServiceStateDisabled, false); 310 MockServiceProcessControl::kServiceStateDisabled, false);
314 311
315 sync_preferences::TestingPrefServiceSyncable* prefs = 312 sync_preferences::TestingPrefServiceSyncable* prefs =
316 profile_.GetTestingPrefService(); 313 profile_.GetTestingPrefService();
317 prefs->SetUserPref( 314 prefs->SetUserPref(
318 prefs::kCloudPrintEmail, 315 prefs::kCloudPrintEmail,
319 new base::StringValue(MockServiceProcessControl::EnabledUserId())); 316 new base::Value(MockServiceProcessControl::EnabledUserId()));
320 317
321 service.Initialize(); 318 service.Initialize();
322 319
323 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 320 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
324 321
325 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 322 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
326 323
327 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 324 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
328 } 325 }
329 326
330 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) { 327 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {
331 TestCloudPrintProxyService service(&profile_); 328 TestCloudPrintProxyService service(&profile_);
332 329
333 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 330 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
334 MockServiceProcessControl::kServiceStateEnabled, false); 331 MockServiceProcessControl::kServiceStateEnabled, false);
335 332
336 sync_preferences::TestingPrefServiceSyncable* prefs = 333 sync_preferences::TestingPrefServiceSyncable* prefs =
337 profile_.GetTestingPrefService(); 334 profile_.GetTestingPrefService();
338 prefs->SetUserPref(prefs::kCloudPrintEmail, 335 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
339 new base::StringValue(std::string()));
340 336
341 service.Initialize(); 337 service.Initialize();
342 service.RefreshStatusFromService(); 338 service.RefreshStatusFromService();
343 339
344 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(), 340 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
345 prefs->GetString(prefs::kCloudPrintEmail)); 341 prefs->GetString(prefs::kCloudPrintEmail));
346 342
347 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 343 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
348 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 344 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
349 345
350 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 346 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
351 } 347 }
352 348
353 TEST_F(CloudPrintProxyPolicyTest, 349 TEST_F(CloudPrintProxyPolicyTest,
354 StartWithPolicySetProxyDisabledThenClearPolicy) { 350 StartWithPolicySetProxyDisabledThenClearPolicy) {
355 TestCloudPrintProxyService service(&profile_); 351 TestCloudPrintProxyService service(&profile_);
356 352
357 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 353 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
358 MockServiceProcessControl::kServiceStateDisabled, false); 354 MockServiceProcessControl::kServiceStateDisabled, false);
359 355
360 sync_preferences::TestingPrefServiceSyncable* prefs = 356 sync_preferences::TestingPrefServiceSyncable* prefs =
361 profile_.GetTestingPrefService(); 357 profile_.GetTestingPrefService();
362 prefs->SetUserPref(prefs::kCloudPrintEmail, 358 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
363 new base::StringValue(std::string()));
364 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 359 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
365 360
366 service.Initialize(); 361 service.Initialize();
367 362
368 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 363 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
369 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 364 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
370 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 365 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
371 } 366 }
372 367
373 TEST_F(CloudPrintProxyPolicyTest, 368 TEST_F(CloudPrintProxyPolicyTest,
374 StartWithPolicySetProxyEnabledThenClearPolicy) { 369 StartWithPolicySetProxyEnabledThenClearPolicy) {
375 TestCloudPrintProxyService service(&profile_); 370 TestCloudPrintProxyService service(&profile_);
376 371
377 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 372 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
378 MockServiceProcessControl::kServiceStateEnabled, false); 373 MockServiceProcessControl::kServiceStateEnabled, false);
379 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 374 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
380 375
381 sync_preferences::TestingPrefServiceSyncable* prefs = 376 sync_preferences::TestingPrefServiceSyncable* prefs =
382 profile_.GetTestingPrefService(); 377 profile_.GetTestingPrefService();
383 prefs->SetUserPref(prefs::kCloudPrintEmail, 378 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
384 new base::StringValue(std::string()));
385 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 379 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
386 380
387 service.Initialize(); 381 service.Initialize();
388 382
389 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 383 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
390 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 384 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
391 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 385 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
392 } 386 }
393 387
394 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) { 388 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) {
395 TestCloudPrintProxyService service(&profile_); 389 TestCloudPrintProxyService service(&profile_);
396 390
397 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 391 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
398 MockServiceProcessControl::kServiceStateDisabled, false); 392 MockServiceProcessControl::kServiceStateDisabled, false);
399 393
400 sync_preferences::TestingPrefServiceSyncable* prefs = 394 sync_preferences::TestingPrefServiceSyncable* prefs =
401 profile_.GetTestingPrefService(); 395 profile_.GetTestingPrefService();
402 prefs->SetUserPref( 396 prefs->SetUserPref(
403 prefs::kCloudPrintEmail, 397 prefs::kCloudPrintEmail,
404 new base::StringValue(MockServiceProcessControl::EnabledUserId())); 398 new base::Value(MockServiceProcessControl::EnabledUserId()));
405 399
406 service.Initialize(); 400 service.Initialize();
407 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 401 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
408 402
409 service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations(); 403 service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations();
410 service.EnableForUser(); 404 service.EnableForUser();
411 405
412 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(), 406 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
413 prefs->GetString(prefs::kCloudPrintEmail)); 407 prefs->GetString(prefs::kCloudPrintEmail));
414 } 408 }
415 409
416 TEST_F(CloudPrintProxyPolicyTest, 410 TEST_F(CloudPrintProxyPolicyTest,
417 StartWithPolicySetProxyEnabledThenClearPolicyAndEnable) { 411 StartWithPolicySetProxyEnabledThenClearPolicyAndEnable) {
418 TestCloudPrintProxyService service(&profile_); 412 TestCloudPrintProxyService service(&profile_);
419 413
420 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 414 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
421 MockServiceProcessControl::kServiceStateEnabled, false); 415 MockServiceProcessControl::kServiceStateEnabled, false);
422 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 416 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
423 417
424 sync_preferences::TestingPrefServiceSyncable* prefs = 418 sync_preferences::TestingPrefServiceSyncable* prefs =
425 profile_.GetTestingPrefService(); 419 profile_.GetTestingPrefService();
426 prefs->SetUserPref(prefs::kCloudPrintEmail, 420 prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
427 new base::StringValue(std::string()));
428 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false)); 421 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
429 422
430 service.Initialize(); 423 service.Initialize();
431 424
432 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 425 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
433 service.EnableForUser(); 426 service.EnableForUser();
434 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 427 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
435 428
436 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 429 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
437 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 430 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
438 431
439 service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations(); 432 service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations();
440 service.EnableForUser(); 433 service.EnableForUser();
441 434
442 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(), 435 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
443 prefs->GetString(prefs::kCloudPrintEmail)); 436 prefs->GetString(prefs::kCloudPrintEmail));
444 } 437 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/session_startup_pref_unittest.cc ('k') | chrome/browser/profiles/profile_window_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698