chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

index 753857b940fee50d6e034fc3b9ad52240ff9ad43..3e62ca442fbb96298e5654559d0fdea6abcf0827 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

@@ -886,7 +886,7 @@ bool FileManagerPrivateInternalComputeChecksumFunction::RunAsync() {

void FileManagerPrivateInternalComputeChecksumFunction::Respond(

const std::string& hash) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- SetResult(base::MakeUnique<base::StringValue>(hash));

+ SetResult(base::MakeUnique<base::Value>(hash));

SendResponse(true);

}