chrome/browser/ui/webui/options/search_engine_manager_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

index 41b1642492dabee1057fb5ec735407d7606fbabb..9979d8bc42d8058e81b7da1238110aa60ada7a8e 100644

--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

@@ -296,7 +296,7 @@ void SearchEngineManagerHandler::CheckSearchEngineInfoValidity(

validity.SetBoolean("name", edit_controller_->IsTitleValid(name));

validity.SetBoolean("keyword", edit_controller_->IsKeywordValid(keyword));

validity.SetBoolean("url", edit_controller_->IsURLValid(url));

- base::StringValue indexValue(modelIndex);

+ base::Value indexValue(modelIndex);

web_ui()->CallJavascriptFunctionUnsafe(

"SearchEngineManager.validityCheckCallback", validity, indexValue);

}