Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: base/test/values_test_util.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/values_test_util.h ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/values_test_util.cc
diff --git a/base/test/values_test_util.cc b/base/test/values_test_util.cc
index 6c1ee7d7fd4f0d7e86732734220326782596dbf4..ab12cfbfd9846294d108ddbb26916b6dc4098291 100644
--- a/base/test/values_test_util.cc
+++ b/base/test/values_test_util.cc
@@ -53,9 +53,8 @@ void ExpectDictStringValue(const std::string& expected_value,
EXPECT_EQ(expected_value, string_value) << key;
}
-void ExpectStringValue(const std::string& expected_str,
- StringValue* actual) {
- std::unique_ptr<StringValue> scoped_actual(actual);
+void ExpectStringValue(const std::string& expected_str, Value* actual) {
+ std::unique_ptr<Value> scoped_actual(actual);
std::string actual_str;
EXPECT_TRUE(scoped_actual->GetAsString(&actual_str));
EXPECT_EQ(expected_str, actual_str);
« no previous file with comments | « base/test/values_test_util.h ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698