components/dom_distiller/core/page_features_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/page_features_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/core/page_features_unittest.cc

diff --git a/components/dom_distiller/core/page_features_unittest.cc b/components/dom_distiller/core/page_features_unittest.cc

index 6d0bea34b80093f921816696808589021c2f74c3..0bfeb142d6978865a51ab1817b1d12bbf3292f78 100644

--- a/components/dom_distiller/core/page_features_unittest.cc

+++ b/components/dom_distiller/core/page_features_unittest.cc

@@ -75,7 +75,7 @@ TEST(DomDistillerPageFeaturesTest, TestCalculateDerivedFeatures) {

std::string stringified_json;

ASSERT_TRUE(base::JSONWriter::Write(*core_features, &stringified_json));

std::unique_ptr<base::Value> stringified_value(

- new base::StringValue(stringified_json));

+ new base::Value(stringified_json));

std::vector<double> derived(

CalculateDerivedFeaturesFromJSON(stringified_value.get()));