Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
index 5ec61e34c43db1d93684f461580498390bca218b..f55ba74fb7a6cf24f746bce810c454c4b2e92bc3 100644
--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
@@ -350,7 +350,7 @@ void LocalDiscoveryUIHandler::DeviceChanged(
base::DictionaryValue info;
- base::StringValue service_key(kKeyPrefixMDns + name);
+ base::Value service_key(kKeyPrefixMDns + name);
if (description.id.empty()) {
info.SetString(kDictionaryKeyServiceName, name);
@@ -372,7 +372,7 @@ void LocalDiscoveryUIHandler::DeviceChanged(
void LocalDiscoveryUIHandler::DeviceRemoved(const std::string& name) {
device_descriptions_.erase(name);
std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();
- base::StringValue name_value(kKeyPrefixMDns + name);
+ base::Value name_value(kKeyPrefixMDns + name);
web_ui()->CallJavascriptFunctionUnsafe(
"local_discovery.onUnregisteredDeviceUpdate", name_value, *null_value);
@@ -600,7 +600,7 @@ void LocalDiscoveryUIHandler::SetupCloudPrintConnectorSection() {
l10n_util::GetStringUTF16(IDS_GOOGLE_CLOUD_PRINT),
base::UTF8ToUTF16(email));
}
- base::StringValue label(label_str);
+ base::Value label(label_str);
web_ui()->CallJavascriptFunctionUnsafe(
"local_discovery.setupCloudPrintConnectorSection", disabled, label,
« no previous file with comments | « chrome/browser/ui/webui/invalidations_message_handler.cc ('k') | chrome/browser/ui/webui/local_state/local_state_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698